This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Updating burrow #91
Closed
Updating burrow #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2019 09:54
Updates Burrow to use the seth-fixes branch, which is based on 0.23. Still a WIP, as we have some functions that are unimplemented and just panic, but don't seem to cause any issues. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
Handles issue stemming from Burrow's issue #908, where a panic occurs if the global permissions address isn't set. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
knkski
requested review from
aludvik,
dplumb94,
grkvlt,
peterschwarz and
vaporos
as code owners
peterschwarz
approved these changes
Jan 3, 2019
|
Depends on hyperledger-archives/burrow#908 being fixed. |
|
@peterschwarz we are still waiting on a response on hyperledger-archives/burrow#908 before planning a fix, are you able to respond to the points there? |
|
Closing due to lack of time to resolve conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Burrow to 0.23, and fixes issue with global permissions.