Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maintainers Guidelines #1

Merged
merged 5 commits into from May 21, 2020
Merged

Add Maintainers Guidelines #1

merged 5 commits into from May 21, 2020

Conversation

tkuhrt
Copy link
Contributor

@tkuhrt tkuhrt commented Apr 30, 2020

Signed-off-by: Kuhrt, Tracy A tracy.a.kuhrt@accenture.com

Signed-off-by: Kuhrt, Tracy A <tracy.a.kuhrt@accenture.com>
@ryjones ryjones requested a review from a team April 30, 2020 22:41
Signed-off-by: Kuhrt, Tracy A <tracy.a.kuhrt@accenture.com>
## What Does Being a Maintainer Entail
The `MAINTAINERS.md` file SHOULD contain information about the different types of maintainers that exist (whole project, repo, part of repo) and what their duties are (e.g., maintainers calls, quarterly reports, code reviews, issue cleansing).

## How to Become a Maintainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should allow for that info to be elsewhere and merely have a link to it in that case because several projects have that info in their docs today. On the other hand, the change this involves is simple and a link could be made the other way around...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping the SHOULD gave that out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but the thing is that we do want to be able to get to that info from the MAINTAINERS file. This is often not the case today. So I think adding something stating that this needs to be in the file or linked from it would give better results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss with rest of @hyperledger/tsc. I was trying to not be too prescriptive with the guidelines.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sympathetic to Tracy's POV here

tkuhrt added 2 commits May 7, 2020 06:50
Signed-off-by: Kuhrt, Tracy A <tracy.a.kuhrt@accenture.com>
Signed-off-by: Kuhrt, Tracy A <tracy.a.kuhrt@accenture.com>
Copy link

@christo4ferris christo4ferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that it includes email etc. Thanks, Tracy!

@hartm
Copy link

hartm commented May 7, 2020

Looks good to me. Thanks Tracy!

## List of Project Maintainers
The first thing that MUST be included in the `MAINTAINERS` file is a list of the project's maintainers, both active and emeritus.

It is recommended that the lists be sorted alphabetically and contain the maintainers name, GitHub ID, LFID, Chat ID, Email, Company Affiliation, and Scope.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear that we recommend at least those fields and that it is not forbidden to add other fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a recommended list of fields. Do you have a suggestion on re-wording?

* There MUST be at least one reliable mechanism to contact the maintainer (either chat ID or email).
* Scope is dependent on the project and may not exist for a given project. Scope could be the whole project, a specific repository, specific directories in a repository, or high-level description of responsibility (e.g., Documentation).

The following shows the suggested format for the information:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to make sure that the maintainers fell free to choose the format they prefer especially if they plan to use GitHub hooks as David was suggesting during the TSC call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. That is why it is a "suggested format"

@ryjones
Copy link
Member

ryjones commented May 7, 2020

I think you have the approvals needed for merge

Signed-off-by: Kuhrt, Tracy A <tracy.a.kuhrt@accenture.com>
Copy link

@christo4ferris christo4ferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryjones ryjones merged commit 24f80ac into hyperledger:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants