Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account creation with custom N, R, P parameters #35

Closed
fraspadafora opened this issue Dec 19, 2016 · 6 comments
Closed

Account creation with custom N, R, P parameters #35

fraspadafora opened this issue Dec 19, 2016 · 6 comments
Labels
enhancement a feature request

Comments

@fraspadafora
Copy link

Hi,
I'm working with Android apps, and the decrypt time for the account is very high.
So i need to create accounts with different N, R, P so it doesn't take that much time.
Is it possible to add a new function in the Wallet class with the possibility to specify these parameters?
Thank you.

@bigstar119
Copy link

hi,i get the same problem with you!! can you tell me how to change the N,R,P to make decrypt time quick?

@fraspadafora
Copy link
Author

The geth mobile lib uses N = 4096 and P = 6
That can be decrypted in 10 seconds more or less.
For this reason I think it is useful to have the possibility to set the N,P and R parameters when an account is created.

@bigstar119
Copy link

change N adn P value make account create faster is good..but does it have security risks? the hacker decrypt it quick also.

@conor10
Copy link
Contributor

conor10 commented Dec 20, 2016

We could potentially lower these values for the Android client. I'll follow up with the Go team on their justification for lowering the value - unless one of you can already provide this insight?

@fraspadafora
Copy link
Author

In the geth mobile library for Android (https://ethereum.github.io/go-ethereum/downloads/) in the AccountManager, they are using the Geth.LightScryptN object with value 4096 and Geth.LightScryptP with value 6 to create a new account.
Of course it is easier to decrypt, but I think it is the compromise to have something usable.
I suggest to store big amounts of money in mist wallets, and less quantity in mobile accounts.

@conor10 conor10 added the enhancement a feature request label Jan 13, 2017
@conor10
Copy link
Contributor

conor10 commented Jan 31, 2017

This functionality has been checked in - expect to see in web3j-android release 1.2.0 in the next week or so.

See https://github.com/web3j/web3j/blob/master/src/main/java/org/web3j/crypto/Wallet.java for details.

@conor10 conor10 closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a feature request
Projects
None yet
Development

No branches or pull requests

3 participants