Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Getter for signer address in TransactionManager interface #61

Closed
androlo opened this issue Mar 6, 2017 · 1 comment
Closed
Labels
enhancement a feature request

Comments

@androlo
Copy link

androlo commented Mar 6, 2017

It would be great if one could get the signer address, so it doesn't have to be stored in multiple places. Getting the address works with the RawTransactionManager of course, through the credentials, but it is not possible from a ClientTransactionManager. At least not in version 2.0.2.

I guess a special accessor directly on ClientTransactionManager would work too but seems a bit clunky, since one of the main uses of the sender address is pre-conditions that guard against sending sure-to-fail transactions (e.g. transactions to permissioned contracts), and those generally depend only on the address and not the transaction method that happen to be used.

Fantastic library btw.

@conor10 conor10 added the enhancement a feature request label Mar 7, 2017
@conor10
Copy link
Contributor

conor10 commented Mar 7, 2017

@conor10 conor10 closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a feature request
Projects
None yet
Development

No branches or pull requests

2 participants