Does Web3.j support Solidity's ABIV2? #935

fabioberger · 2019-05-20T15:47:45Z

Many projects (including 0x) uses the somewhat new ABIV2 feature from Solidity. Does Web3.j already support contracts that use it?

For more information about ABIV2, grep for ABIEncoderV2 in the Solidity release notes or read Ethers.js's blog post about the feature.

esaulpaugh · 2019-05-26T00:47:57Z

https://github.com/esaulpaugh/headlong supports it. I would like to see headlong incorporated into web3j at some point. Currently web3j is developing its own implementation.

fabioberger · 2019-05-28T10:25:12Z

@esaulpaugh any idea if Web3.j's own implementation supports ABIV2?

esaulpaugh · 2019-05-28T20:40:52Z

Yes, I believe this is the work in progress https://github.com/web3j/web3j/tree/feature/653-solidity-structs

iikirilov · 2019-07-18T23:54:24Z

that work has gone stale - would be cool if someone can pick it up. I will probably get around to it someday but I have other priorities now.

hazae41 · 2019-11-02T12:35:38Z

bump

any news?

esaulpaugh · 2019-11-05T16:16:12Z

@hazae41 relevant: #832

Ferparishuertas · 2020-12-04T12:41:57Z

Is there any plan to support struct arrays support as @RobertoArtiles mentioned on #1206 ? @iikirilov

conor10 · 2020-12-07T17:45:40Z

Given the interest here, I'll see what we can do to make this happen.

Let me speak with the team.

cryptoDevTrader · 2020-12-24T17:14:04Z

Given the interest here, I'll see what we can do to make this happen.

Let me speak with the team.

Has any progress or decision been made on this? It looks like ABIv2 is now default with the release of Solidity v0.8.0.

conor10 · 2021-01-03T14:21:39Z

PR #1321 has been created which adds structs array support - it would be great to get input from those on this thread to verify our test coverage is complete enough for their use case.
Thanks to @sweexordious for all the work here.

rach-id · 2021-01-08T16:19:49Z

Fixed and merged 🎉 Now we have support for arrays of structs and multiple arrays of structs returns. Closing...
Reopen if needed.

Ferparishuertas · 2021-03-03T10:08:44Z

Hi mates

Thanks for this functionality. It has been very helpful for us, enabling to work on a more structured language way making smart contracts more efficient and readable.

Having said that... using the feature for a while we found a bug decoding strings inside anidated structs.

With the following Smart contract

pragma solidity ^0.7.5;

pragma experimental ABIEncoderV2;

contract Web3jTest {


   struct Address {

       string city;

       string postalCode;

   }


   struct Structure {

       uint256 id;

       string description;

       Address _address;

       bytes notaryDocument;

   }

   Structure private structure;

   function set(Structure memory _structure) external returns(bool) {

       structure = _structure;

       return true;

   }


   function get() external view returns(Structure memory structure_) {

       structure_ = structure;

   }


}

To test the SC we made this quick /dirty test

try {

  Web3jTest web3jTest = Web3jTest.deploy(web3j, transactionManager, gasProvider).send();

  web3jTest.set(new Web3jTest.Structure(BigInteger.ONE, "This is a description", new Web3jTest.Address("This a city", "This is a postal code"), "This is a notarized document".getBytes(StandardCharsets.UTF_8))).send();

  Web3jTest.Structure structure = web3jTest.get().send();

  log.debug("structure: ", structure.toString());

} catch (Exception e) {

  e.printStackTrace();

}

Executing this code the error is the following

java.lang.StringIndexOutOfBoundsException: String index out of range: -234

at java.lang.String.substring(String.java:1967)

at org.web3j.abi.TypeDecoder.decodeDynamicParameterFromStruct(TypeDecoder.java:583)

at org.web3j.abi.TypeDecoder.decodeDynamicStructElements(TypeDecoder.java:546)

at org.web3j.abi.TypeDecoder.decodeDynamicStruct(TypeDecoder.java:472)

at org.web3j.abi.TypeDecoder.decodeDynamicParameterFromStruct(TypeDecoder.java:588)

at org.web3j.abi.TypeDecoder.decodeDynamicStructElements(TypeDecoder.java:546)

at org.web3j.abi.TypeDecoder.decodeDynamicStruct(TypeDecoder.java:472)

at org.web3j.abi.DefaultFunctionReturnDecoder.build(DefaultFunctionReturnDecoder.java:94)

at org.web3j.abi.DefaultFunctionReturnDecoder.decodeFunctionResult(DefaultFunctionReturnDecoder.java:52)

at org.web3j.abi.FunctionReturnDecoder.decode(FunctionReturnDecoder.java:49)

at org.web3j.tx.Contract.executeCall(Contract.java:322)

at org.web3j.tx.Contract.executeCallSingleValueReturn(Contract.java:328)

at org.web3j.tx.Contract.executeCallSingleValueReturn(Contract.java:339)

at org.web3j.tx.Contract.lambda$executeRemoteCallSingleValueReturn$1(Contract.java:428)

at org.web3j.protocol.core.RemoteCall.send(RemoteCall.java:42)

rach-id · 2021-03-05T09:35:49Z

@Ferparishuertas Thank you for reporting this.
I will try to reproduce it and come back to you.

rach-id · 2021-03-14T18:24:04Z

@Ferparishuertas Sorry for the late answer.
Please check the following PR #1383
I added the structs you had issue with as a test case and everything is green currently.
Let me know if there are additional cases you are having issues with. Your input is valuable.

Thank you

lfrKain · 2021-03-24T18:37:16Z

@sweexordious thank you so much for your help.
We have found some cases with more complex structs that are still failing in your branch when decoding string fields.
Here is the smart contract example:

pragma solidity ^0.7.5;

pragma experimental ABIEncoderV2;

contract Web3jTest {

    struct Struct2 {
        string string1;
        uint256 uintField1;
        uint256 uintField2;
        uint256 uintField3;
        string string2;
    }

    struct Struct1 {
        uint256 uintField1;
        uint256 uintField2;
    }

    struct MainStruct {
        uint256 id;
        string name;
        Struct1 struct1;
        Struct2 struct2;
    }

    MainStruct private structure;

    function set(MainStruct memory _structure) external returns(bool) {
        structure = _structure;
        return true;
    }

    function get() external view returns(MainStruct memory structure_) {
        structure_ = structure;
    }
}

when trying this

Web3jTest web3jTest = Web3jTest.deploy(web3j, transactionManager, gasProvider).send();
web3jTest.set(new Web3jTest.MainStruct(
	BigInteger.ONE,
	"test name",
	new Web3jTest.Struct1(BigInteger.TEN, BigInteger.ZERO),
	new Web3jTest.Struct2(
		"test string 1",
		BigInteger.ONE,
		BigInteger.ZERO,
		BigInteger.TEN,
		"test string 2"
	)
)).send();
Web3jTest.MainStruct mainStruct = web3jTest.get().send();

we get this error, always with index 64:

java.lang.StringIndexOutOfBoundsException: String index out of range: 64

	at java.lang.String.substring(String.java:1963)
	at org.web3j.abi.TypeDecoder.decodeUintAsInt(TypeDecoder.java:275)
	at org.web3j.abi.TypeDecoder.decodeDynamicBytes(TypeDecoder.java:312)
	at org.web3j.abi.TypeDecoder.decodeUtf8String(TypeDecoder.java:324)
	at org.web3j.abi.TypeDecoder.decode(TypeDecoder.java:112)
	at org.web3j.abi.TypeDecoder.decode(TypeDecoder.java:122)
	at org.web3j.abi.TypeDecoder.decodeDynamicParameterFromStruct(TypeDecoder.java:597)
	at org.web3j.abi.TypeDecoder.decodeDynamicStructElements(TypeDecoder.java:545)
	at org.web3j.abi.TypeDecoder.decodeDynamicStruct(TypeDecoder.java:471)
	at org.web3j.abi.DefaultFunctionReturnDecoder.build(DefaultFunctionReturnDecoder.java:94)
	at org.web3j.abi.DefaultFunctionReturnDecoder.decodeFunctionResult(DefaultFunctionReturnDecoder.java:52)
	at org.web3j.abi.FunctionReturnDecoder.decode(FunctionReturnDecoder.java:49)
	at org.web3j.tx.Contract.executeCall(Contract.java:295)
	at org.web3j.tx.Contract.executeCallSingleValueReturn(Contract.java:301)
	at org.web3j.tx.Contract.executeCallSingleValueReturn(Contract.java:312)
	at org.web3j.tx.Contract.lambda$executeRemoteCallSingleValueReturn$1(Contract.java:400)
	at org.web3j.protocol.core.RemoteCall.send(RemoteCall.java:42)

thanks in advance

rach-id · 2021-03-24T18:47:13Z

@lfrKain Thank you so much for letting me know. Will try to work on a more global fix for this.

BarBozz · 2021-05-08T23:45:35Z

@sweexordious would be very nice to get a more pluggable solution. I am using maven plugin and had to compile a web3j from scratch and the maven plugin due to not distributed on maven repositories and a chain of dependencies.

Didnt find any doc howto handle codegen / solc config independently.

** Structs are not working anymore for me **

pragma solidity >=0.7.0;
pragma experimental ABIEncoderV2;

interface SomeInterface {
    struct SomeStruct {
        address addressA;
        address addressB;
    }

    function someFunction(SomeStruct calldata params) external payable returns (uint256 result);
}

is not working - i get the tuple error mentioned in #1361

rach-id · 2021-05-09T09:08:54Z

@BarBozz I am able to compile the interface that you provided no problem.
Can you please let us know which versions are you using ?
I am using latest web3j version 4.8.4 via the web3j-gradle-plugin:4.8.4

1742268440Zhy · 2022-01-18T08:33:14Z

Yes, I believe this is the work in progress https://github.com/web3j/web3j/tree/feature/653-solidity-structs

But how to package and install it? I see that the source code is provided on Git, there is no corresponding installation package

iikirilov mentioned this issue May 31, 2019

Unsupported type encountered: tuple , while generating Contract Wrappers #927

Closed

iikirilov added the enhancement a feature request label Jul 19, 2019

AlexandrouR mentioned this issue Aug 2, 2019

Getting error: Empty value (0x) returned from contract when using string[] as a parameter #691

Closed

This was referenced Aug 20, 2019

Incorrect decoding of string arrays from contract calls #867

Closed

Is passing struct as argument in solidity contract supported in web3j? #653

Closed

iikirilov mentioned this issue Nov 18, 2019

[Bounty] Support AbiV2 #1103

Closed

cryptoDevTrader mentioned this issue Dec 11, 2020

Unsupported type encountered: tuple hyperledger/web3j-maven-plugin#60

Open

rach-id closed this as completed Jan 8, 2021

conor10 reopened this Mar 5, 2021

mohamedelshami closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2022

Gelassen mentioned this issue Feb 2, 2023

Get StringIndexOutOfBoundsException when receive result as a dynamic array with single struct #1858

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does Web3.j support Solidity's ABIV2? #935

Does Web3.j support Solidity's ABIV2? #935

fabioberger commented May 20, 2019

esaulpaugh commented May 26, 2019

fabioberger commented May 28, 2019

esaulpaugh commented May 28, 2019

iikirilov commented Jul 18, 2019

hazae41 commented Nov 2, 2019

esaulpaugh commented Nov 5, 2019

Ferparishuertas commented Dec 4, 2020

conor10 commented Dec 7, 2020

cryptoDevTrader commented Dec 24, 2020

conor10 commented Jan 3, 2021

rach-id commented Jan 8, 2021

Ferparishuertas commented Mar 3, 2021 •

edited

Loading

rach-id commented Mar 5, 2021

rach-id commented Mar 14, 2021

lfrKain commented Mar 24, 2021 •

edited

Loading

rach-id commented Mar 24, 2021

BarBozz commented May 8, 2021 •

edited

Loading

rach-id commented May 9, 2021

1742268440Zhy commented Jan 18, 2022

Does Web3.j support Solidity's ABIV2? #935

Does Web3.j support Solidity's ABIV2? #935

Comments

fabioberger commented May 20, 2019

esaulpaugh commented May 26, 2019

fabioberger commented May 28, 2019

esaulpaugh commented May 28, 2019

iikirilov commented Jul 18, 2019

hazae41 commented Nov 2, 2019

esaulpaugh commented Nov 5, 2019

Ferparishuertas commented Dec 4, 2020

conor10 commented Dec 7, 2020

cryptoDevTrader commented Dec 24, 2020

conor10 commented Jan 3, 2021

rach-id commented Jan 8, 2021

Ferparishuertas commented Mar 3, 2021 • edited Loading

rach-id commented Mar 5, 2021

rach-id commented Mar 14, 2021

lfrKain commented Mar 24, 2021 • edited Loading

rach-id commented Mar 24, 2021

BarBozz commented May 8, 2021 • edited Loading

rach-id commented May 9, 2021

1742268440Zhy commented Jan 18, 2022

Ferparishuertas commented Mar 3, 2021 •

edited

Loading

lfrKain commented Mar 24, 2021 •

edited

Loading

BarBozz commented May 8, 2021 •

edited

Loading