Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept SIGTERM #2

Open
thewilkybarkid opened this issue Dec 10, 2019 · 3 comments
Open

Accept SIGTERM #2

thewilkybarkid opened this issue Dec 10, 2019 · 3 comments

Comments

@thewilkybarkid
Copy link

Seen the same problem as hypermedia-app/generic.hypermedia.app#46.

Refs libero/article-store#104 (comment).

@tpluscode
Copy link
Member

I'm not sure. This container is not using sh -c entrypoint and I seem to have no trouble stopping it with SIGTERM

@thewilkybarkid
Copy link
Author

Had to add --init in libero/article-store@d2b6501 to get it to work...

@giorgiosironi
Copy link

The ENTRYPOINT is:

"Entrypoint": [
                "node",
                "entrypoint.js"
            ],

so the difference with hypermedia-app/generic.hypermedia.app#46 is that there is no npm that can receive signals, but only node. Would have to setup signal handlers in code usually to deal with SIGTERM.

Can reproduce by removing --init from libero/article-store#104 but not sure what to run to have a minimal test case just with this image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants