Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize .isSameNode() on large components #118

Closed
bcomnes opened this issue Mar 12, 2017 · 2 comments
Closed

Utilize .isSameNode() on large components #118

bcomnes opened this issue Mar 12, 2017 · 2 comments
Milestone
Winamp 2

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Mar 12, 2017

Whenever you change the volume, you end up re-rendering everything over and over. This is super wasteful and starts to creak under load.

Components affected by this:

Worse case scenario is that we have to manage large data sets outside of state and use pointers in state. But lets experiment with that first.
@bcomnes bcomnes added this to the Winamp 2 milestone Mar 12, 2017
@bcomnes bcomnes mentioned this issue Mar 12, 2017
Closed
@bcomnes
Copy link
Contributor Author

bcomnes commented Mar 23, 2017

Or use https://github.com/yoshuawuyts/nanocomponent

@bcomnes
Copy link
Contributor Author

bcomnes commented Apr 20, 2017

Done with the introduction of https://github.com/hypermodules/cache-component

@bcomnes bcomnes closed this as completed Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Winamp 2
Development

No branches or pull requests
1 participant
@bcomnes