New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progressbar with tqdm #455
Conversation
@PhilipMay very cool, thanks for this. don't see a reason not to have it on by default, but it might be good to have a switch to turn it off. I have a lib or two that have hyperopt as dependency and I'm worried that this might clutter the output unfavourably in between other stuff. btw, how does this look in distributed setup (mongo etc.)? |
I am working on it. Will tell you when I am done. |
awesome, looking forward to it. |
@maxpumperla I added a redirect that will avoid this type of clutter. See here: 63a44e5 All your normal The Progressbar also shows the best (minimum) loss it has found. Like this:
|
Well, for mongo you pass a I am pretty sure that they are handled by the same loop that is inside my progress bar. So yes it should work. |
I am done with my work here with the PR. The python 2.7 build is still broken though. :-( |
When should I extend the documentation? https://github.com/hyperopt/hyperopt.github.io |
@PhilipMay I tested locally, works with 2.7. Let's fix travis after this PR. Same goes for docs. Thanks for the contribution, please keep it up! :) |
Was fun to implement it and discuss it here. ! :-) |
Thankful for this! Great job! |
This is a nice feature to have, but unexpected output like this breaks doctests. Before this PR, I managed to silence hyperopt's output by setting the logger verbose level. However, it no longer works now. Since I also think having |
I added the progressbar. See #454
It can not be turned off and is on by default.
But I can add this if wanted.
The progressbar also shows the best (lowest loss).
Would be happy for feedback.
Philip