Use SwiftHash #81
Use SwiftHash #81
Conversation
onmyway133
commented
Apr 28, 2017
•
onmyway133
commented
- Use the homegrown SwiftHash, it contains just 1 file
- I've tested it a lot, even with https://github.com/minimaxir/big-list-of-naughty-strings
- This is not about file size, there's no problem with CryptoSwift, it's just about taste 馃槇
|
@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @attila-at-hyper and @vadymmarkov to be potential reviewers. |
|
|
||
| return string | ||
| } else { | ||
| return key.base64() |
There was a problem hiding this comment.
If it sometimes can't md5, then we fallback to base64, which will cause inconsistency
|
@onmyway133 you have some merge conflicts that you need to resolve here. @vadymmarkov what do you think? Should we switch from CryptoSwift to SwiftHash? 馃槑 |
|
@zenangst @onmyway133 Could |
|
Using CryptoSwift also lets us take advantage of performance/bug fixes in a well-established, widely used library. |
|
Yeah after today's discussions it would probably be smart to stick with CryptoSwift! |
|
@hyperoslo/ios I think we all agree that we don't want to go in this direction? Close PR? |
|
馃槩 |
|
Sorry @onmyway133, these things happen hugs |
