Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update podspec to use Swift 4.1 #20

Merged
merged 8 commits into from
Apr 3, 2018
Merged

Update podspec to use Swift 4.1 #20

merged 8 commits into from
Apr 3, 2018

Conversation

onmyway133
Copy link
Owner

@anderscarling
Copy link
Contributor

anderscarling commented Apr 3, 2018 •
edited
Loading

Not sure you actually need to explicitly set SWIFT_VERSION to 4.1.

When I use xcode build settings to set Swift Language Version to Swift 4.1 it will just set SWIFT_VERSION to 4.0 in the .xcodeproj.

Might be me misunderstanding something though, if so I would love to be enlightened! :)

@onmyway133
Copy link
Owner Author

@anderscarling Hi, I don't know if it is still required now, but it was a problem last time for us.

@onmyway133 onmyway133 merged commit b133709 into master Apr 3, 2018
@onmyway133 onmyway133 deleted the fix/swift4.1 branch April 3, 2018 13:13
@onmyway133 onmyway133 mentioned this pull request Apr 3, 2018
Open
@anderscarling
Copy link
Contributor

@onmyway133 Are you looking to release these changes anytime soon? :)

@onmyway133
Copy link
Owner Author

@anderscarling Hi, I just released it to CocoaPods, can you check https://github.com/hyperoslo/Cheers/releases/tag/2.1.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymmarkov vadymmarkov vadymmarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onmyway133 @anderscarling @vadymmarkov