Fix low quality thumbnails with Xcode 11 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lars-fosaas Any chance you can check this PR? Thanks! |
ezisazis
approved these changes
Jan 17, 2020
|
ping @lars-fosaas Tried it, it works well |
|
@lars-fosaas ping |
|
Thanks @bruno-aguiar ! |
|
@3lvis Thanks for finally merging this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the project with Xcode 11, the default value for
PHImageRequestOptions.resizeModeis.fast. This causes thePHImageManagerto send lower resolution images which appear blurred when displayed in the photo picker cells.Xcode 10, iPhone 6s, default value ->
.none: 256x342, sometimes 256x454Xcode 11, iPhone 6s, default value ->
.fast: 92x124 (looks blurred)Changes
resizeModeto.none.noneis the default value when building the project with Xcode 10.(Open in new tab for better comparison)