improve permissions logic #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onmyway133, @zenangst, please, look at my PRs :) |
|
@geor-kasapidi Hi, sorry for late response. This goes a bit far from our design, but I like the idea. We will refactor this within the swift 4 transition. Thanks for the PR 🚀 |
|
@onmyway133 thank you! |
|
is anyone else still getting the camera permission prompts? My project never show the camera tab anymore, even on fresh start, i have all the plist item and pre 2.0 version all shows. for some reason the check() method never trigger the request anymore. any tips on how to fix that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'v found camera man saves photos into assets. It means that Photos permission is always required. Also, if user wants to pickup images from gallery, but do not want to use camera, we also have to show gallery controller instead of permission blocker.