Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option. Use .DelayPlaceholder to delay the setting of the placeholder #21

Closed
wants to merge 2 commits into from

Conversation

onmyway133
Copy link
Contributor

Add Option. For now it is just delay the setting of the placeholder.

There are cases like the profile page and user changes the profile picture

  • If this is the first time user changes the picture, it should display the placeholder -> actual image
  • If this is the next time user changes the picture, it should only display the placeholder if the image fetching fails

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @RamonGilabert and @vadymmarkov to be potential reviewers

@onmyway133
Copy link
Contributor Author

And we need unit test as well 😁

@aashishdhawan
Copy link
Contributor

aashishdhawan commented Jun 8, 2016

If this is the first time user changes the picture, it should display the placeholder -> actual image
If this is the next time user changes the picture, it should only display the placeholder if the image fetching fails

@onmyway133 I think we should not handle this in Imaginary itself but the place where we are using it. We should try to make public API as simple as it can be but not simpler.

@vadymmarkov
Copy link
Contributor

@onmyway133 Should we resolve conflicts and merge or close this one? 😄

@onmyway133
Copy link
Contributor Author

@aashishdhawan @vadymmarkov I agree that this is a bit customization and not for generic usage. But this is something that can only be done inside Imaginary. So I'm not sure if we should continue with this approach or not. Basically, there are some more options to come, and more logic checking in the code if we go with this 😈

@onmyway133
Copy link
Contributor Author

This PR is too old, close for now

@onmyway133 onmyway133 closed this Oct 12, 2016
@onmyway133 onmyway133 deleted the fix/delay_placeholder branch October 12, 2016 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants