Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development question #296

Closed
alexanderkhitev opened this issue Feb 21, 2023 · 4 comments
Closed

Development question #296

alexanderkhitev opened this issue Feb 21, 2023 · 4 comments

Comments

@alexanderkhitev
Copy link

Hey guys! Thank you for creating this great framework. I just investigate the code and I'm wondering about one thing. Why did you use UIScrollView as the base view instead UICollectionView?

@3lvis
Copy link
Collaborator

3lvis commented Feb 21, 2023

Hi,

I would assume it's because UIScrollView is more versatile and no specific features from UICollectionView where required at the time.

@alexanderkhitev
Copy link
Author

Hi,

I would assume it's because UIScrollView is more versatile and no specific features from UICollectionView where required at the time.

Ok, thank you for answer. I just wondering about performance. For example: If the user opens a data set with ~ 1500 image items, can it be a problem? Thanks

@3lvis
Copy link
Collaborator

3lvis commented Feb 21, 2023

If I'm not mistaken Lightbox should have pagination built-in where a few screens are reused as you scroll, so 1500 image items shouldn't be a performance / memory problem.

@alexanderkhitev
Copy link
Author

Hey @3lvis ! Ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants