Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use instance variables for request/response data. #11

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Use instance variables for request/response data. #11

merged 1 commit into from
Apr 29, 2016

Conversation

frodsan
Copy link
Contributor

@frodsan frodsan commented Apr 29, 2016

I think this would be more friendly for threaded
servers. I think request/response data shouldn't
be shared.

I think this would be more friendly for threaded
servers. I don't think request/response data should
be shared.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 99.123% when pulling ae90956 on frodsan:fix-server-thread into eb83df7 on hyperoslo:master.

@frodsan
Copy link
Contributor Author

frodsan commented Apr 29, 2016

@frodsan
Copy link
Contributor Author

frodsan commented Apr 29, 2016

If you want to keep the current version, I think you can use local variables and then pass request and response to receive and verify.

@jgorset
Copy link
Owner

jgorset commented Apr 29, 2016

This is a lot nicer. Thanks @frodsan!

@jgorset jgorset merged commit 0630204 into jgorset:master Apr 29, 2016
@frodsan frodsan deleted the fix-server-thread branch April 29, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants