Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See the full screen MetaMask wallet view within HyperPlay #52

Closed
jacobc-eth opened this issue Dec 5, 2022 · 6 comments
Closed

See the full screen MetaMask wallet view within HyperPlay #52

jacobc-eth opened this issue Dec 5, 2022 · 6 comments

Comments

@jacobc-eth
Copy link
Contributor

jacobc-eth commented Dec 5, 2022

As a user with the MetaMask browser extension selected as my wallet method, I'd like to see the full screen wallet view within HyperPlay so that I'll be able to fully manage my wallet.

description

For these extension users, they'll need a way to access the MetaMask full screen view (navigate to: chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/home.html ).

This should most likely be a new menu item on the sidebar so as to avoid replacing the onboarding / connect wallet menu.

ac

  • Only show new menu items if relevant wallet connection has been selected
  • Open in browser view on top of HyperPlay
  • 80% of total screensize with blur in background
  • add menu item
@pimentel08
Copy link

No UI change.

UX Change: When user selects "MetaMask Extension", the web view (80%) will open up to start MM onboarding. After they have successfully logged in to MM, the MM modal will appear.

Will the modal be movable? TBD

@BrettCleary
Copy link
Collaborator

BrettCleary commented Dec 15, 2022

We are currently doing this through a separate window since we can't use a webview tag to embed it in the React DOM tree (because it is sandboxed and doesn't have access to our chrome extended api) and have to use an electron Browser View. This also is the best pattern as the chrome event we are handling is a generic 'createTab' event that can be called for multiple purposes (e.g. the portfolio view). Furthermore Electron specifically recommends to not use the webview tag as it is unstable https://www.electronjs.org/docs/latest/api/webview-tag.

@BrettCleary
Copy link
Collaborator

Show the portfolio view and home page links in the sidebar. navigate to these pages when the "createTab" event is called with those html pages.

@BrettCleary
Copy link
Collaborator

Need to investigate how to show the html pages in the react dom since webview tag is sandboxed

@BrettCleary BrettCleary self-assigned this Jan 5, 2023
@BrettCleary
Copy link
Collaborator

PR in progress here: #83

@BrettCleary
Copy link
Collaborator

I will leave the sidebar like this on this PR and the sidebar UI redesign can be done on a separate PR image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants