Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sustainability] Refactor game info platform type #627

Open
BrettCleary opened this issue Nov 8, 2023 · 0 comments
Open

[Sustainability] Refactor game info platform type #627

BrettCleary opened this issue Nov 8, 2023 · 0 comments

Comments

@BrettCleary
Copy link
Collaborator

We should condense all of our platform strings on game info into shared ones across all game stores (separate PR). Right now we have a leaky abstraction with different store naming conventions for platforms propagating everywhere throughout the app.

We should define a common interface for stores and enforce all stores to meet this standard the store specific naming would only be used within each store manager in that case. I think we probably only need "Windows, Linux, macOS or Browser" and the _amd64 etc can be inferred by the current arch with a storeManager internal helper function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant