Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser games are missing MM in full overlay when the wallet is locked #685

Open
nyghtstalker opened this issue Dec 19, 2023 · 1 comment
Open

Browser games are missing MM in full overlay when the wallet is locked #685

nyghtstalker opened this issue Dec 19, 2023 · 1 comment
Labels
Severity: 2 - Medium Moderate impact affecting a smaller subset of users or non-critical functionality. Type: Bug Something isn't working

Comments

@nyghtstalker
Copy link

nyghtstalker commented Dec 19, 2023 •
edited
Loading

Describe the bug

MM is missing from the full overlay when a user is playing a browser game and their wallet is locked. This does stop wallet sign requests.

NOTE: After the wallet is unlocked it works as expected. This is not occurring on native games.

Add logs

(11:15:27) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version
(11:15:27) INFO:    [Legendary]:        Legendary location: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary
(11:15:27) INFO:    [Gog]:              GOGDL location: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl
(11:15:27) INFO:    [Backend]:          Loading MetaMask extension
(11:15:27) INFO:    [Connection]:       Connectivity: check-online
(11:15:27) INFO:    [Connection]:       Pinging external endpoints
(11:15:27) INFO:    [Backend]:          Creating abort controller for legendary-version
(11:15:27) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version
(11:15:27) INFO:    [Legendary]:        Legendary location: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary
(11:15:27) INFO:    [Gog]:              GOGDL location: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl
(11:15:27) INFO:    [Gog]:              GOGDL location: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl
(11:15:27) INFO:    [Legendary]:        installed.json updated, refreshing library
(11:15:27) INFO:    [Backend]:          Registered protocol with OS.
(11:15:27) INFO:    [Backend]:          App is starting in headless mode = undefined isCLINoGui = false startInTray = undefined
(11:15:28) INFO:    [Backend]:          MetaMask extension loaded
(11:15:28) INFO:    [Connection]:       Connectivity: online
(11:15:28) INFO:    [Backend]:          User Not Found, removing it from Store
(11:15:28) ERROR:   [Gog]:              Unable to syncQueued playtime, userData not present
(11:15:28) INFO:    [Backend]:          Deleting abort controller for legendary-version
(11:15:28) INFO:    [Backend]:          Deleting abort controller for legendary-version
(11:15:28) INFO:    [Backend]:          Creating abort controller for gogdl-version
(11:15:28) INFO:    [Gog]:              Running command: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\Joe\AppData\Roaming\hyperplay\gog_store\auth.json --version
(11:15:29) INFO:    [Backend]:          Creating abort controller for gogdl-version
(11:15:29) INFO:    [Gog]:              Running command: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\Joe\AppData\Roaming\hyperplay\gog_store\auth.json --version
(11:15:29) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(11:15:29) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(11:15:29) INFO:    [Backend]:          Creating abort controller for nile-version
(11:15:29) INFO:    [Nile]:             Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\nile_config C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\nile --version
(11:15:29) INFO:    [Backend]:          Creating abort controller for nile-version
(11:15:29) INFO:    [Nile]:             Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\nile_config C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\nile --version
(11:15:29) INFO:    [Backend]:          Auto Updater found version: 0.10.0 released on Wed Dec 13 2023 15:19:50 GMT-0800 (Pacific Standard Time) with name 0.10.0
(11:15:30) INFO:    [Backend]:          Loading Screen Ready
(11:15:30) INFO:    [Backend]:          Frontend Ready
(11:15:30) INFO:    [Frontend]:         Refreshing hyperplay Library
(11:15:30) INFO:    [WineDownloader]:   Updating wine versions info
(11:15:30) INFO:    [WineDownloader]:   Fetching upstream information...
(11:15:30) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(11:15:30) INFO:    [Gog]:              Found 0 game(s) to update
(11:15:31) INFO:    [WineDownloader]:   wine versions updated
(11:15:31) ERROR:   [Backend]:          Could not find default wine version
(11:15:31) INFO:    [Backend]:          Deleting abort controller for nile-version
(11:15:31) INFO:    [Backend]:          Deleting abort controller for nile-version
(11:15:35) INFO:    [Backend]:          Starting the Download Queue
(11:15:43) INFO:    [Backend]:          

HyperPlay Version: 0.10.0
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.7.3
Nile Version: 1.0.0 Jonathan Joestar

OS: Microsoft Windows 10 Education KERNEL: 10.0.19045 ARCH: x64
CPU: Intel Core™ i7-6700K @4 
RAM: Total: 63.96 GiB Available: 43.99 GiB
GRAPHICS: GPU0: NVIDIA GeForce RTX 2060 VRAM: 12288MB DRIVER: 545.84 


(11:15:44) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for Untitled Platformer
(11:15:44) INFO:    [HyperPlay]:        Getting install info for Untitled Platformer
(11:15:44) INFO:    [HyperPlay]:        Getting install info for Untitled Platformer
(11:15:44) INFO:    [HyperPlay]:        Getting install info for Untitled Platformer
(11:15:45) INFO:    [Backend]:          

HyperPlay Version: 0.10.0
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.7.3
Nile Version: 1.0.0 Jonathan Joestar

OS: Microsoft Windows 10 Education KERNEL: 10.0.19045 ARCH: x64
CPU: Intel Core™ i7-6700K @4 
RAM: Total: 63.96 GiB Available: 43.94 GiB
GRAPHICS: GPU0: NVIDIA GeForce RTX 2060 VRAM: 12288MB DRIVER: 545.84 


(11:15:45) INFO:    [Backend]:          Launching Untitled Platformer (0x9abbe447c9f00063a649ff7d2b9ee9aae0b29abbed7c0fd28bbd991273825d63)
(11:15:45) INFO:    [Backend]:          Completing HyperPlay Quest
(11:15:45) INFO:    [Backend]:          Preventing display from sleep
(11:15:45) INFO:    [Backend]:          Creating abort controller for 0x9abbe447c9f00063a649ff7d2b9ee9aae0b29abbed7c0fd28bbd991273825d63
(11:15:45) INFO:    [HyperPlay]:        Getting install info for Untitled Platformer
(11:15:45) INFO:    [HyperPlay]:        Getting install info for Untitled Platformer
(11:15:46) ERROR:   [Backend]:          Failed to complete summon task: Unauthorized
(11:16:04) INFO:    [Backend]:          Creating abort controller for legendary-version
(11:16:04) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version
(11:16:04) INFO:    [Backend]:          Creating abort controller for gogdl-version
(11:16:04) INFO:    [Gog]:              Running command: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\Joe\AppData\Roaming\hyperplay\gog_store\auth.json --version
(11:16:04) INFO:    [Backend]:          Creating abort controller for 98bc04bc842e4906993fd6d6644ffb8d
(11:16:04) INFO:    [Legendary]:        Checking if EOS Overlay is enabled: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info
(11:16:05) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(11:16:05) INFO:    [Backend]:          Deleting abort controller for legendary-version
(11:16:09) INFO:    [Backend]:          Aborting 98bc04bc842e4906993fd6d6644ffb8d
(11:16:09) INFO:    [Backend]:          Aborted 98bc04bc842e4906993fd6d6644ffb8d
(11:16:09) INFO:    [Legendary]:        Abort command "XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info"
(11:16:09) INFO:    [Backend]:          Deleting abort controller for 98bc04bc842e4906993fd6d6644ffb8d
(11:16:09) INFO:    [Backend]:          Creating abort controller for 98bc04bc842e4906993fd6d6644ffb8d
(11:16:09) INFO:    [Legendary]:        Checking if EOS Overlay is enabled: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info
(11:16:10) INFO:    [Backend]:          Aborting 98bc04bc842e4906993fd6d6644ffb8d
(11:16:10) INFO:    [Backend]:          Aborted 98bc04bc842e4906993fd6d6644ffb8d
(11:16:10) INFO:    [Legendary]:        Abort command "XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info"
(11:16:10) INFO:    [Backend]:          Deleting abort controller for 98bc04bc842e4906993fd6d6644ffb8d

Steps to reproduce

  1. Make sure a wallet is ATTACHED and LOCKED
  2. Launch a browser game
  3. Open the overlay
  4. Observe that MM is missing in the overlay

Expected behavior

MM should be displayed in the overlay

Screenshots

image

hyperplay Version

Latest Stable

System Information

  • Windows, Ubuntu, Mac
  • hyperplay Version 0.10

Additional information

No response
@nyghtstalker nyghtstalker added Type: Bug Something isn't working Severity: 2 - Medium Moderate impact affecting a smaller subset of users or non-critical functionality. labels Dec 19, 2023
@nyghtstalker
Copy link
Author

When the game is launched with the wallet locked this is what is displayed now

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Severity: 2 - Medium Moderate impact affecting a smaller subset of users or non-critical functionality. Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyghtstalker