New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vacuum mask eels #2183
Vacuum mask eels #2183
Conversation
…nt across methods using navigation or signal mask.
…m_mask_eels # Conflicts: # hyperspy/_signals/eels.py # hyperspy/_signals/signal1d.py # hyperspy/ui_registry.py
…m_mask_eels # Conflicts: # hyperspy/signal.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work for me insofar as I understand it should from the tests provided.
It seems to me that for consistency there should be a super().decomposition() for EELSSpectrum in the same way that there is for EDSTEMSpectrum with a flag to use this method to determine a vacuum mask for decomposition as default.
Other than this, and minor typos - looks good to me
…m_mask_eels # Conflicts: # hyperspy/signal.py
@ericpre can you deal with the very minor comments I had so that this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the comments from @dnjohnstone , there's a couple of merge conflicts.
Requires the merge conflicts to be resolved plus a few of the above comments |
…m_mask_eels # Conflicts: # hyperspy/_signals/signal1d.py # hyperspy/learn/mva.py # hyperspy/tests/signal/test_eels.py
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2183 +/- ##
======================================================
+ Coverage 75.85% 75.88% +0.03%
======================================================
Files 202 202
Lines 29623 29650 +27
Branches 6446 6454 +8
======================================================
+ Hits 22470 22501 +31
+ Misses 5336 5330 -6
- Partials 1817 1819 +2
Continue to review full report at Codecov.
|
…m_mask_eels # Conflicts: # hyperspy/tests/signal/test_eels.py
Is that everything now @ericpre? |
Yes, this is good now. Increasing coverage made me find a bug with the navigation mask of the |
Similarly to the way it can be currently done with
EDSSpectrum
, this PR add avacuum_mask
method to theEELSSpectrum
signal.Progress of the PR
vacuum_mask
method toEELSSpectrum
,navigation_mask
in thequantification
method of EDS signal, which was ignored.Minimal example of the bug fix or the new feature