Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some components do not have function_nd method #2225

Open
7 of 9 tasks
thomasaarholt opened this issue Jul 27, 2019 · 1 comment
Open
7 of 9 tasks

Some components do not have function_nd method #2225

thomasaarholt opened this issue Jul 27, 2019 · 1 comment

Comments

@thomasaarholt
Copy link
Contributor

thomasaarholt commented Jul 27, 2019

The purpose of this issue is to highlight that some components are missing a function_nd method, which represents low-hanging fruit in some cases, and slightly more difficult (and desired) fruit in other cases.

@ericpre added the component.function_nd method, which gracefully lets one calculate a component's data array for the entire navigation space. I'm personally very grateful for this addition as it simplifies some of my code.

There are still some components that miss this method. Most notably, the ScaleableFixedPattern and the EELSCLEdge. I think the former is easy to implement, but @ericpre did you have a go at implementing the EELSCLEdge component? When I tried to create a similar method while working on #1477, I had difficulty with one of the aspects of the EELS component (I think it was the fine structure).

All components based on the Expression component automatically gain the function_nd method. The remaining components are listed below:

@jlaehne jlaehne mentioned this issue Sep 7, 2019
17 tasks
@thomasaarholt
Copy link
Contributor Author

thomasaarholt commented Jun 20, 2020

@ericpre this is not as required any longer for the linear fitting, at least with the two coming implementations. I think its still very nice to have though, for generating large numbers of varying components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants