Non uniform axes #2399
Merged
Non uniform axes #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inear-axis_FunctionalDA
if `x` is not None
This reverts commit c977edd.
Nua value2index fix
value2index: convert index to int
…niform_axes # Conflicts: # hyperspy/_signals/complex_signal.py # hyperspy/misc/array_tools.py # hyperspy/tests/io/test_blockfile.py
|
@francisco-dlp, are you happy with getting this PR merged? The test suite is failing because of the release of pillow 8.3: python-pillow/Pillow#5571 and it is not related to this PR? |
|
Unfortunately I won't have time for a detailed review in the next few weeks. I have just had a quick look and tested some features and it looks great to me. There are of course things to polish and features to add, but I think that the current state is good enough to expose the feature to users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2398 for a tracking issue. Checkout the hyperspy branch
non_uniform_axesfor testing.