Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add height property to the Gaussian2D component #2688

Merged

Conversation

magnunor
Copy link
Contributor

@magnunor magnunor commented Mar 22, 2021

Progress of the PR

  • Added height property
  • update docstring
  • add entry to CHANGES.rst
  • add test
  • ready for review

Example

import hyperspy.api as hs
g = hs.model.components2D.Gaussian2D()
print(g.height) # 0.15915494309189535
g.A.value = 100
print(g.height) # 15.915494309189533
g.sigma_x.value = 2
print(g.height) # 7.957747154594767

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2688 (b82298b) into RELEASE_next_minor (edd3b4b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_minor    #2688   +/-   ##
===================================================
  Coverage               77.14%   77.15%           
===================================================
  Files                     202      202           
  Lines                   30226    30230    +4     
  Branches                 6607     6607           
===================================================
+ Hits                    23319    23323    +4     
  Misses                   5117     5117           
  Partials                 1790     1790           
Impacted Files Coverage Δ
hyperspy/_components/gaussian2d.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd3b4b...b82298b. Read the comment docs.

hyperspy/_components/gaussian2d.py Outdated Show resolved Hide resolved
hyperspy/_components/gaussian2d.py Outdated Show resolved Hide resolved
hyperspy/tests/component/test_gaussian2d.py Outdated Show resolved Hide resolved
@magnunor
Copy link
Contributor Author

All done!

@jlaehne jlaehne merged commit 78c7974 into hyperspy:RELEASE_next_minor Mar 22, 2021
@ericpre ericpre added this to the v1.7 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants