Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read scanning size for recent empad dataset #2757

Merged
merged 2 commits into from Jun 3, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented May 31, 2021

Close #2755.

Progress of the PR

  • Fix parsing scanning size for empad dataset acquired with software version 1.2.0
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • add tests,
  • ready for review.

@ericpre
Copy link
Member Author

ericpre commented May 31, 2021

@xiongh15 this pull request should fix the issue you reported in #2755.

If you are comfortable with installing a development version of python library, you can do it running the following command:

pip install https://github.com/ericpre/hyperspy/archive/refs/heads/fix_empad_v1.2.0.zip

If not, better to wait that this fix is included in a release version.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2757 (1518ae6) into RELEASE_next_patch (6d184cd) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2757   +/-   ##
===================================================
  Coverage               77.30%   77.30%           
===================================================
  Files                     202      202           
  Lines                   30032    30034    +2     
  Branches                 6561     6562    +1     
===================================================
+ Hits                    23216    23218    +2     
  Misses                   5068     5068           
  Partials                 1748     1748           
Impacted Files Coverage Δ
hyperspy/io_plugins/empad.py 93.68% <66.66%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d184cd...1518ae6. Read the comment docs.

@ericpre ericpre added this to the v1.6.3 milestone May 31, 2021
@jlaehne jlaehne linked an issue Jun 2, 2021 that may be closed by this pull request
@jlaehne
Copy link
Contributor

jlaehne commented Jun 3, 2021

LGTM

@jlaehne jlaehne merged commit 49be975 into hyperspy:RELEASE_next_patch Jun 3, 2021
@ericpre ericpre deleted the fix_empad_v1.2.0 branch June 3, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error happened when i tried to read empad .xml
2 participants