New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix complex rebin and add complex test #2789
fix complex rebin and add complex test #2789
Conversation
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2789 +/- ##
===================================================
Coverage 77.36% 77.36%
===================================================
Files 202 202
Lines 30105 30105
Branches 6579 6579
===================================================
Hits 23290 23290
Misses 5067 5067
Partials 1748 1748
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, can you please add an entry for the changelog as mentioned in the PR template - see https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/upcoming_changes/README.rst for more details?
Sorry I did not read that template attentively and now it's gone. Maybe it would be good to put that info in the developer documentation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No worries! Yes, it would be good to see how this can be improved, but at the same time information should not be duplicated, because very often, one duplicate get outdated... Also as a new contributor, if you have any other comments on what is not clear, this is more than welcome!
Yes, this is merged now! We use zenodo to reference hyperspy and the contributor list is pulled automatically from the github contributor profile. If you want to be credited with your full name, you need to update your github profile. Adding affiliation may be good too, because we use it sometimes for conference abstract, etc. |
My second try to fix rebinning of complex signals, as suggested by @ericpre:
See discussion in #2788.