New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drawstyle plot_histogram #2810
Merged
jlaehne
merged 8 commits into
hyperspy:RELEASE_next_patch
from
ericpre:fix_plot_histogram
Oct 7, 2021
Merged
Fix drawstyle plot_histogram #2810
jlaehne
merged 8 commits into
hyperspy:RELEASE_next_patch
from
ericpre:fix_plot_histogram
Oct 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpre
force-pushed
the
fix_plot_histogram
branch
from
August 24, 2021 18:13
76d3096
to
97316e3
Compare
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2810 +/- ##
======================================================
+ Coverage 77.37% 77.42% +0.05%
======================================================
Files 202 202
Lines 30108 30108
Branches 6579 6578 -1
======================================================
+ Hits 23295 23312 +17
+ Misses 5066 5051 -15
+ Partials 1747 1745 -2
Continue to review full report at Codecov.
|
ericpre
force-pushed
the
fix_plot_histogram
branch
from
August 24, 2021 18:24
97316e3
to
4d520af
Compare
jlaehne
reviewed
Oct 4, 2021
jlaehne
approved these changes
Oct 7, 2021
A few more corrections to the docstring, otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress of the PR
hs.plot_plot_histograms
drawstyle - see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.3.0.html#passing-line2d-s-drawstyle-together-with-linestyle-is-removedupcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature