Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawstyle plot_histogram #2810

Merged
merged 8 commits into from Oct 7, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 24, 2021

Progress of the PR

Minimal example of the bug fix or the new feature

import hyperspy.api as hs
import numpy as np

img = hs.signals.Signal2D(np.random.chisquare(1,[10,10,100]))
img2 = hs.signals.Signal2D(np.random.chisquare(2,[10,10,100]))
ax = hs.plot.plot_histograms([img, img2], legend=['hist1', 'hist2'])

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #2810 (4bdeb85) into RELEASE_next_patch (69e8a23) will increase coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2810      +/-   ##
======================================================
+ Coverage               77.37%   77.42%   +0.05%     
======================================================
  Files                     202      202              
  Lines                   30108    30108              
  Branches                 6579     6578       -1     
======================================================
+ Hits                    23295    23312      +17     
+ Misses                   5066     5051      -15     
+ Partials                 1747     1745       -2     
Impacted Files Coverage Δ
hyperspy/drawing/utils.py 73.11% <92.30%> (+2.80%) ⬆️
hyperspy/misc/eels/eelsdb.py 60.86% <0.00%> (-4.35%) ⬇️
hyperspy/axes.py 86.34% <0.00%> (ø)
hyperspy/_signals/lazy.py 90.67% <0.00%> (ø)
hyperspy/signal.py 76.24% <0.00%> (+0.03%) ⬆️
hyperspy/io.py 84.18% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e8a23...4bdeb85. Read the comment docs.

hyperspy/drawing/utils.py Outdated Show resolved Hide resolved
hyperspy/drawing/utils.py Show resolved Hide resolved
hyperspy/drawing/utils.py Outdated Show resolved Hide resolved
hyperspy/drawing/utils.py Outdated Show resolved Hide resolved
hyperspy/drawing/utils.py Outdated Show resolved Hide resolved
@jlaehne
Copy link
Contributor

jlaehne commented Oct 7, 2021

A few more corrections to the docstring, otherwise LGTM.

@jlaehne jlaehne merged commit dc7bd4d into hyperspy:RELEASE_next_patch Oct 7, 2021
@ericpre ericpre deleted the fix_plot_histogram branch October 7, 2021 13:26
@ericpre ericpre added this to the v1.6.5 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants