New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for cliff-lorimer quantification #2822
Bugfix for cliff-lorimer quantification #2822
Conversation
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2822 +/- ##
======================================================
+ Coverage 80.08% 80.12% +0.03%
======================================================
Files 209 209
Lines 32581 32574 -7
Branches 7335 7333 -2
======================================================
+ Hits 26094 26099 +5
+ Misses 4736 4725 -11
+ Partials 1751 1750 -1
Continue to review full report at Codecov.
|
Thanks @thomasaarholt, but as you would have anticipated, this would a test! If you don't have time, then someone else should finish the PR. |
Does anyone have time to add tests? Should be low hanging fruits. |
84f1392
to
289cce6
Compare
…t type and length
289cce6
to
4f58b0e
Compare
add changelog entry? |
Description of the change
if absorption_correction is not None
led toabsorption_correction = absorption_correction
, which was unnecessary.I'm afraid that I don't have time to add tests.
Progress of the PR