Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for cliff-lorimer quantification #2822

Merged

Conversation

thomasaarholt
Copy link
Contributor

Description of the change

  • There would be an an error on quantifying a single array of intensities due to a typo
  • Several if absorption_correction is not None led to absorption_correction = absorption_correction, which was unnecessary.
    I'm afraid that I don't have time to add tests.

Progress of the PR

  • Change implemented (can be split into several points),
  • ready for review.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #2822 (717e41b) into RELEASE_next_minor (836e7df) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           RELEASE_next_minor    #2822      +/-   ##
======================================================
+ Coverage               80.08%   80.12%   +0.03%     
======================================================
  Files                     209      209              
  Lines                   32581    32574       -7     
  Branches                 7335     7333       -2     
======================================================
+ Hits                    26094    26099       +5     
+ Misses                   4736     4725      -11     
+ Partials                 1751     1750       -1     
Impacted Files Coverage Δ
hyperspy/_signals/eds_tem.py 83.73% <100.00%> (+0.22%) ⬆️
hyperspy/misc/eds/utils.py 92.55% <100.00%> (+4.94%) ⬆️
hyperspy/io_plugins/jeol.py 85.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836e7df...717e41b. Read the comment docs.

@ericpre
Copy link
Member

ericpre commented Sep 9, 2021

Thanks @thomasaarholt, but as you would have anticipated, this would a test! If you don't have time, then someone else should finish the PR.
From the coverage, it seems that the missing case is: CL quantification of a single spectrum with absorption_correction=None.

@jlaehne
Copy link
Contributor

jlaehne commented Feb 21, 2022

Does anyone have time to add tests? Should be low hanging fruits.

@jlaehne
Copy link
Contributor

jlaehne commented Apr 14, 2022

add changelog entry?

@ericpre ericpre requested a review from jlaehne April 14, 2022 11:23
@jlaehne jlaehne merged commit a3e249a into hyperspy:RELEASE_next_minor Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants