Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 #2839

Merged
merged 3 commits into from Nov 2, 2021
Merged

Drop python 3.6 #2839

merged 3 commits into from Nov 2, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 21, 2021

This is based on #2797 to show that the test failure works fine and also because it includes the fixes for the latest version of h5py (3.5).
Only the last two commits are relevant, once #2797 has been merged, I will rebase this branch if necessary and the changes will mcuh more simple.

Progress of the PR

  • Drop support for python 3.6,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@ericpre ericpre added this to the v1.7 milestone Oct 21, 2021
@ericpre ericpre marked this pull request as draft October 21, 2021 12:39
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2839 (bd5616c) into RELEASE_next_minor (707e1f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_minor    #2839   +/-   ##
===================================================
  Coverage               77.11%   77.11%           
===================================================
  Files                     206      206           
  Lines                   31600    31600           
  Branches                 6918     6918           
===================================================
  Hits                    24367    24367           
  Misses                   5482     5482           
  Partials                 1751     1751           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707e1f9...bd5616c. Read the comment docs.

@ericpre ericpre marked this pull request as ready for review October 30, 2021 20:25
@ericpre ericpre mentioned this pull request Nov 1, 2021
@jlaehne jlaehne merged commit 4a7e59c into hyperspy:RELEASE_next_minor Nov 2, 2021
@ericpre ericpre deleted the drop_python36 branch November 2, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants