Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix hydrogenic gdos k edge #2859

Merged

Conversation

daenjannis
Copy link
Contributor

@daenjannis daenjannis commented Nov 23, 2021

Description of the change

Bug fix for the gdos of the hydrogen k edge.

Progress of the PR

  • Change implemented (can be split into several points),
  • update docstring (if appropriate),
  • update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2859 (1a96dc7) into RELEASE_next_patch (6cf2351) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2859   +/-   ##
===================================================
  Coverage               75.68%   75.68%           
===================================================
  Files                     202      202           
  Lines                   30113    30113           
  Branches                 6578     6578           
===================================================
  Hits                    22791    22791           
  Misses                   5586     5586           
  Partials                 1736     1736           
Impacted Files Coverage Δ
hyperspy/misc/eels/hydrogenic_gos.py 92.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf2351...1a96dc7. Read the comment docs.

@francisco-dlp
Copy link
Member

Great, thanks!

Fixes #2854

@francisco-dlp francisco-dlp merged commit 319c00b into hyperspy:RELEASE_next_patch Nov 24, 2021
@ericpre ericpre added this to the v1.7 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants