New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-ENH update cutoff_at_kV behavior for bruker.py reader #2910
Conversation
* `None` does no cutoff * introduced acceptance of "auto" which cuts at last nonzero value * previous behavior with None can be activated with "lowest_constraint" value
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2910 +/- ##
======================================================
+ Coverage 79.37% 79.56% +0.18%
======================================================
Files 208 209 +1
Lines 31939 32270 +331
Branches 7194 7242 +48
======================================================
+ Hits 25353 25677 +324
- Misses 4837 4839 +2
- Partials 1749 1754 +5
Continue to review full report at Codecov.
|
fix some size vs index +1/-1 issues
updated cutoff_at_kV under Bruker Composit Files
adoption of exmples to cutoff_at_kV change
looks that fixing the behaviour of cutoff_at_kV makes it behaves similarly to jeol reader where None does not do any hideous auto cutting, I think I should also now address and change docstring of common reader. I see it also has downsampling. I think there could be separate PR to look through all of readers and find same keywords to update. I think this PR is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have left some questions/suggestions.
@ericpre , what do you think about the changes made? ("auto" to "last_non-zero"; "lowest_constraint" to "em_hv") |
Thanks, this looks good to me! |
squashed last 12. Is it enough? I was unfortunately mobile and I don't know how on github I could edit few files and commit a bunch. Thus such an amount of commits... |
Description of the change
Changes how bruker.py reader reacts to cutoff_at_kV:
None
as value does no more any cutoff"zealous"
which cuts at last nonzero value"auto"
, with updated fallback if hv=0This partly fixes the #2898
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)