Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering event range widget #2952

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jun 3, 2022

Fix #2950 and some errors when plotting or updating a Signal1D plot with an empty slice of data.

Progress of the PR

  • Trigger event when widget is changed (910e854)
  • avoid error with calculating limits in autoscaling code of Signal1D which occurs when plotting an empty slice of data
  • improve coverage
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@ericpre ericpre added this to the v1.7.1 milestone Jun 3, 2022
@ericpre ericpre linked an issue Jun 3, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #2952 (455ec3d) into RELEASE_next_patch (90b0349) will increase coverage by 0.02%.
The diff coverage is 89.47%.

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2952      +/-   ##
======================================================
+ Coverage               80.76%   80.78%   +0.02%     
======================================================
  Files                     209      209              
  Lines                   32688    32691       +3     
  Branches                 7318     7320       +2     
======================================================
+ Hits                    26401    26411      +10     
+ Misses                   4522     4516       -6     
+ Partials                 1765     1764       -1     
Impacted Files Coverage Δ
hyperspy/roi.py 85.17% <ø> (+0.44%) ⬆️
hyperspy/drawing/signal1d.py 80.05% <88.23%> (+1.31%) ⬆️
hyperspy/drawing/_widgets/range.py 89.65% <100.00%> (+0.08%) ⬆️
hyperspy/interactive.py 86.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b0349...455ec3d. Read the comment docs.

@ericpre ericpre mentioned this pull request Jun 3, 2022
@ericpre ericpre mentioned this pull request Jun 3, 2022
@francisco-dlp francisco-dlp merged commit a6f5ca1 into hyperspy:RELEASE_next_patch Jun 8, 2022
@ericpre ericpre deleted the fix_event_range_widget branch June 8, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpanROI broken?
2 participants