New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack
raises error when stacking signals that contain a variance signal
#2954
Conversation
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2954 +/- ##
======================================================
- Coverage 80.87% 80.80% -0.07%
======================================================
Files 209 209
Lines 32654 32698 +44
Branches 7313 7322 +9
======================================================
+ Hits 26408 26421 +13
- Misses 4483 4514 +31
Partials 1763 1763
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than adding a test, as mentioned by @jlaehne, it looks good!
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature
The following raises an error without this fix: