Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors reported by lgtm.com #2966

Open
jlaehne opened this issue Jun 18, 2022 · 2 comments
Open

Fix errors reported by lgtm.com #2966

jlaehne opened this issue Jun 18, 2022 · 2 comments

Comments

@jlaehne
Copy link
Contributor

jlaehne commented Jun 18, 2022

Language grade: Python Total alerts

The code checker lgtm has a number of errors, warnings and recommendations for HyperSpy. We should use that to consolidate our code:

https://lgtm.com/projects/g/hyperspy/hyperspy

@jlaehne
Copy link
Contributor Author

jlaehne commented Jun 21, 2022

lgtm.com definitely includes some false-positives, but also identifies some real issues or chances for better code consistency.

For LumiSpy, I have now activated PR commenting by lgtm - takes a fairly long time (even though the project is still small), but can help to find some code inconsistencies that might be missed by manual review.

@jlaehne
Copy link
Contributor Author

jlaehne commented Jun 22, 2022

I reported three types of false positives to LGTM that affect us:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant