Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7 #3144

Merged
merged 9 commits into from May 6, 2023
Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented May 6, 2023

Progress of the PR

  • Drop python 3.7,
  • update minimum version of dependencies and simplify code accordingly,
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

@ericpre ericpre added this to the v2.0 Split milestone May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (e9461e1) 80.67% compared to head (7a5b1f1) 80.79%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_major    #3144      +/-   ##
======================================================
+ Coverage               80.67%   80.79%   +0.11%     
======================================================
  Files                     176      176              
  Lines                   24512    24479      -33     
  Branches                 5713     5707       -6     
======================================================
+ Hits                    19775    19777       +2     
+ Misses                   3402     3382      -20     
+ Partials                 1335     1320      -15     
Impacted Files Coverage Δ
hyperspy/_components/error_function.py 100.00% <ø> (+18.18%) ⬆️
hyperspy/_components/skew_normal.py 91.00% <ø> (+1.57%) ⬆️
hyperspy/_components/voigt.py 93.10% <ø> (+2.78%) ⬆️
hyperspy/learn/svd_pca.py 95.71% <ø> (ø)
hyperspy/model.py 86.73% <ø> (+0.12%) ⬆️
hyperspy/_components/power_law.py 97.22% <100.00%> (-0.08%) ⬇️
hyperspy/_signals/lazy.py 90.86% <100.00%> (+0.94%) ⬆️
hyperspy/learn/mva.py 82.91% <100.00%> (-0.02%) ⬇️
hyperspy/misc/utils.py 91.53% <100.00%> (+0.07%) ⬆️
hyperspy/signal.py 77.73% <100.00%> (+0.10%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ericpre ericpre requested review from jlaehne and CSSFrancis May 6, 2023 17:05
Copy link
Member

@CSSFrancis CSSFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@CSSFrancis CSSFrancis merged commit bfafb1c into hyperspy:RELEASE_next_major May 6, 2023
26 checks passed
@ericpre ericpre deleted the drop_python3.7 branch May 8, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants