New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IPython and IParallel optional #3145
Merged
jlaehne
merged 5 commits into
hyperspy:RELEASE_next_major
from
ericpre:ipython_optional
Jul 14, 2023
Merged
Make IPython and IParallel optional #3145
jlaehne
merged 5 commits into
hyperspy:RELEASE_next_major
from
ericpre:ipython_optional
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3145 +/- ##
======================================================
+ Coverage 81.23% 81.36% +0.12%
======================================================
Files 176 176
Lines 24409 24406 -3
Branches 5683 5681 -2
======================================================
+ Hits 19829 19857 +28
+ Misses 3274 3244 -30
+ Partials 1306 1305 -1
☔ View full report in Codecov by Sentry. |
ericpre
force-pushed
the
ipython_optional
branch
2 times, most recently
from
May 7, 2023 08:41
ba002f3
to
6bca2a4
Compare
4 tasks
ericpre
force-pushed
the
ipython_optional
branch
2 times, most recently
from
May 18, 2023 17:45
e70b7ac
to
eae849f
Compare
jlaehne
approved these changes
May 27, 2023
ericpre
force-pushed
the
ipython_optional
branch
from
June 11, 2023 05:32
eae849f
to
f2778f4
Compare
…haviour is correct when running in a script
ericpre
force-pushed
the
ipython_optional
branch
from
July 13, 2023 13:22
f2778f4
to
1d42d2d
Compare
ericpre
force-pushed
the
ipython_optional
branch
from
July 13, 2023 13:27
1d42d2d
to
abd7004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress of the PR
print_*
functions, which were not printing when running from a script, they were only printing when running in notebook or qtconsole. Now allprint_*
functions behave consistently: they all print the output and doesn't return an object, which was an str or html. The ipythondisplay
will pick the correct rendering when running in an "ipython" context, for example notebook, qtconsole.fancy
to someprint_*
functions, which wasn't doing anything,upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature
To test the
print_*
funtions: