New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EELS functional fine structure #3206
EELS functional fine structure #3206
Conversation
I would like this to be included in the |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3206 +/- ##
======================================================
+ Coverage 81.29% 81.40% +0.10%
======================================================
Files 173 173
Lines 24212 24312 +100
Branches 5627 5672 +45
======================================================
+ Hits 19684 19792 +108
+ Misses 3225 3208 -17
- Partials 1303 1312 +9
☔ View full report in Codecov by Sentry. |
@francisco-dlp This looks good! My plan was to finish splitting the EDS and EELS once #3148 is finished. The good thing about splitting things is that once the EELS EDS is split it doesn't really matter if this is released before/after 2.0.0 as we can just make a minor release in the EELS EDS package. That being said, I was hoping that we can make a release candidate for the 2.0.0 in the next month or so and then we can go through the process of updating the downstream packages so most likely this won't occur in that time frame (unless people have substantial time to work on these things. |
@francisco-dlp, not much happen in August, would you be able to add documentation and tests in the coming week? If not, maybe just an example to check that this is working when moving code around? |
Yes, I'll add docs this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice!
I suspect that they will conflict with #3082 when it get merge with RELEASE_next_major
. I can do the rebase if this helps.
loss probability caused by the interactions with the material's electronic structure. | ||
It offers insights into the material's electronic properties, bonding, and local environments. | ||
Therefore, we cannot model them from first-principles because i) the material is usually unknown | ||
ii) HyperSpy only supports Hydrogenic and Hartree-Slater EELS core-loss models. Instead, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since #3082, there is support for other GOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. What about "HyperSpy only supports atomic simulations" instead?
Once I polish this a little and add the test, it'll be ready for review.
This is now ready for review. |
Co-authored-by: Jonas Lähnemann <jonas@pdi-berlin.de>
Co-authored-by: Jonas Lähnemann <jonas@pdi-berlin.de>
Main feature
Currently the fine structure of
EELSCLEdge
s is hardcoded as a spline. This adds the possibilty to use otherComponents
asEELSCLEdge
fine strucuture.To implement the feature, this adds 3 attributes to
EELSModel
:ext_fine_structure
fine_structure_components
: aset
to add the fine structure componentsint_fine_structure
fine_structure_spline
fine_structure_spline_active
:bool
. WhenTrue
, the spline fine structure feature is active. It can be combined withfine_structure_components
.fine_structure_onset
fine_structure_spline_onset
: the energy (from the onset) from where to use the "standard" fine structure. This can beNone
.where_ext_fine_structure_zero
Other changes
EELSCLEdge
methodsfix_fine_structure
andfree_fine_structure
Example
TODO