New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot_spectra heatmap should take kwarg as well #3219
plot_spectra heatmap should take kwarg as well #3219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstrings on **kwargs
needs to be updated, for now, it says "Has no effect on 'heatmap' style."
It also needs a changelog entry - this is useful to inform user of change of behaviour but also for developer to keep track when changes have implemented.
Can you rebase the changes on the RELEASE_next_major
branch, because we are aiming at releasing hyperspy 2.0 mid-Sept. and working on that branch will avoid us to merge the RELEASE_next_minor
into the RELEASE_next_major
.
As title, currently plot_spectra heatmap does not take kwarg for .plot().
Hi Eric, I change the doc for plot_spectra and added a changelog entry. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3219 +/- ##
===================================================
Coverage 81.31% 81.31%
===================================================
Files 173 173
Lines 24206 24206
Branches 5623 5623
===================================================
Hits 19683 19683
Misses 3223 3223
Partials 1300 1300
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested clarifications/more details for the docstring.
Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
As title, currently plot_spectra heatmap does not take kwarg for .plot().