Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resizers #3222

Merged
merged 4 commits into from Sep 2, 2023
Merged

Fix resizers #3222

merged 4 commits into from Sep 2, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Sep 1, 2023

Fix #3213.

Progress of the PR

  • Check if reziser patches are drawn before removing them,,
  • Don't display resizers when adding the widget to the figure (widget not selected) for consistency with unselected state,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.03% 🎉

Comparison is base (24d9a39) 81.27% compared to head (d694e39) 81.31%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_major    #3222      +/-   ##
======================================================
+ Coverage               81.27%   81.31%   +0.03%     
======================================================
  Files                     173      173              
  Lines                   24204    24206       +2     
  Branches                 5622     5623       +1     
======================================================
+ Hits                    19672    19683      +11     
+ Misses                   3233     3223      -10     
- Partials                 1299     1300       +1     
Files Changed Coverage Δ
hyperspy/drawing/widget.py 73.19% <80.00%> (+1.76%) ⬆️
hyperspy/misc/test_utils.py 90.41% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit c9a3881 into hyperspy:RELEASE_next_major Sep 2, 2023
11 of 20 checks passed
@ericpre ericpre deleted the fix_resizers branch September 2, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages when using 2 RectangularROI.
2 participants