Scipy deprecation #3225
Merged
Scipy deprecation #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3225 +/- ##
===================================================
Coverage 81.31% 81.31%
===================================================
Files 173 173
Lines 24206 24206
Branches 5623 5623
===================================================
Hits 19683 19683
Misses 3223 3223
Partials 1300 1300 ☔ View full report in Codecov by Sentry. |
ericpre
reviewed
Sep 7, 2023
| @@ -36,8 +36,8 @@ added before calling :py:meth:`~.roi.BaseInteractiveROI.interactive`. | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| >>> import scipy.misc | |||
| >>> im = hs.signals.Signal2D(scipy.misc.ascent()) | |||
| >>> import scipy.datasets | |||
There was a problem hiding this comment.
Simplify to the following here in other places as elsewhere, scipy.ndimage is also used.
Suggested change
| >>> import scipy.datasets | |
| >>> import scipy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Replace the deprecated usage of
scipy.miscbyscipy.datasetsin the documentation.See https://docs.scipy.org/doc/scipy/reference/generated/scipy.misc.ascent.html
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)