Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated scipy.interpolate.interp1d #3233

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Sep 25, 2023

Fix #3223. This uses scipy.interpolate.make_interp_spline and masked array to deal with np.nan.

Progress of the PR

  • Replace scipy.interpolate.interp1d with scipy.interpolate.make_interp_spline
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@ericpre ericpre changed the title Replace deprecated scipy.interpolate.interp1d with `scipy.interpola… Replace deprecated scipy.interpolate.interp1d Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b1d4de9) 81.38% compared to head (d08b12f) 81.30%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_major    #3233      +/-   ##
======================================================
- Coverage               81.38%   81.30%   -0.09%     
======================================================
  Files                     173      173              
  Lines                   24352    24348       -4     
  Branches                 5677     5676       -1     
======================================================
- Hits                    19818    19795      -23     
- Misses                   3222     3245      +23     
+ Partials                 1312     1308       -4     
Files Coverage Δ
hyperspy/_components/scalable_fixed_pattern.py 100.00% <100.00%> (ø)
hyperspy/_signals/signal1d.py 79.84% <100.00%> (+0.12%) ⬆️
hyperspy/misc/eels/base_gos.py 90.58% <100.00%> (ø)
hyperspy/misc/eels/hydrogenic_gos.py 92.70% <100.00%> (ø)
hyperspy/signal.py 77.73% <ø> (ø)
hyperspy/signal_tools.py 74.27% <85.71%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre
Copy link
Member Author

ericpre commented Sep 26, 2023

@CSSFrancis, can you review this PR please? :)

Copy link
Member

@CSSFrancis CSSFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge. This should require changes to the hyperpsy_gui packages as well correct?

@ericpre
Copy link
Member Author

ericpre commented Sep 26, 2023

This looks good to merge. This should require changes to the hyperpsy_gui packages as well correct?

Yes, that's right.

@ericpre ericpre merged commit 3634d2a into hyperspy:RELEASE_next_major Sep 26, 2023
24 of 25 checks passed
@ericpre ericpre deleted the replace_interp1d_deprecated branch September 26, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants