New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated scipy.interpolate.interp1d
#3233
Replace deprecated scipy.interpolate.interp1d
#3233
Conversation
scipy.interpolate.interp1d
with `scipy.interpola…scipy.interpolate.interp1d
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3233 +/- ##
======================================================
- Coverage 81.38% 81.30% -0.09%
======================================================
Files 173 173
Lines 24352 24348 -4
Branches 5677 5676 -1
======================================================
- Hits 19818 19795 -23
- Misses 3222 3245 +23
+ Partials 1312 1308 -4
☔ View full report in Codecov by Sentry. |
…te.make_interp_spline`
e5e4f54
to
d08b12f
Compare
@CSSFrancis, can you review this PR please? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to merge. This should require changes to the hyperpsy_gui packages as well correct?
Yes, that's right. |
Fix #3223. This uses
scipy.interpolate.make_interp_spline
and masked array to deal withnp.nan
.Progress of the PR
scipy.interpolate.interp1d
withscipy.interpolate.make_interp_spline
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)