Testing: Test import of future versions of files. #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_patch #3241 +/- ##
===================================================
Coverage 80.97% 80.97%
===================================================
Files 209 209
Lines 32814 32818 +4
Branches 7540 7542 +2
===================================================
+ Hits 26570 26576 +6
+ Misses 4488 4486 -2
Partials 1756 1756
☔ View full report in Codecov by Sentry. |
|
Should it be based on the patch branch as this would be for a patch release? |
ericpre
force-pushed
the
load_future_files
branch
from
49600c7
to
e0a3698
Compare
ericpre
changed the base branch from
RELEASE_next_minor
to
RELEASE_next_patch
Yes! |
3 tasks
ericpre
force-pushed
the
load_future_files
branch
from
e0a3698
to
ab4f29a
Compare
ericpre
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small change to the release next minor which makes it possible to load files that are saved with no name/ units.
We should probably hold this until after 2.0.0 is released and then we can merge it to keep some continuity.