New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pep 660 editable installs in extension #3252
Add support for pep 660 editable installs in extension #3252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3252 +/- ##
======================================================
- Coverage 80.84% 80.78% -0.06%
======================================================
Files 140 140
Lines 20361 20364 +3
Branches 4821 4820 -1
======================================================
- Hits 16460 16451 -9
- Misses 2827 2840 +13
+ Partials 1074 1073 -1
☔ View full report in Codecov by Sentry. |
172d6a3
to
32af168
Compare
32af168
to
9eb4983
Compare
@ericpre So if I understand this correctly this should better handle installing hyperspy and extension packages in the development mode using pip? |
Yes, but only for extensions using |
Considering the scope of this changes, I don't think that this is worth testing on CI, because it is something that will very rarely. |
@CSSFrancis, did you have to check it? |
Sorry, I've been out of the office the last couple of days. I'll check it tonight! I have an M1 Mac that I can try |
@ericpre This appears to work on an M1 Mac as well. |
Thanks @CSSFrancis! |
To allow using pyproject.toml based builds in extension and simplify packaging of the split extension.
Relevant documentation:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)