New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename datasets to data and tidy up submodule #3253
Rename datasets to data and tidy up submodule #3253
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3253 +/- ##
======================================================
- Coverage 80.78% 80.78% -0.01%
======================================================
Files 140 140
Lines 20364 20360 -4
Branches 4820 4820
======================================================
- Hits 16451 16447 -4
Misses 2840 2840
Partials 1073 1073
☔ View full report in Codecov by Sentry. |
As this is a simple API break, I would suggest to make get it in 2.0! |
f884a89
to
27e3a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Shorten
hs.datasets.artificial_data.get_wave_image
tohs.data.wave_image
. Since theeelsdb
and other datasets has moved toexspy
, we don't need theartificial_data
module.Progress of the PR
datasets
submodule todata
and removeartificial_data
,data
moduleupcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)