Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.12 #3256

Merged
merged 1 commit into from Nov 30, 2023
Merged

Python3.12 #3256

merged 1 commit into from Nov 30, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 5, 2023

Based on #3255 and needs hyperspy/rosettasciio#180

Progress of the PR

  • Add python 3.12 to the test suite,
  • add python 3.12 to setup.py,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (224dca7) 80.86% compared to head (0ad4242) 80.86%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           RELEASE_next_major    #3256   +/-   ##
===================================================
  Coverage               80.86%   80.86%           
===================================================
  Files                     140      140           
  Lines                   20399    20399           
  Branches                 4825     4825           
===================================================
+ Hits                    16495    16496    +1     
  Misses                   2829     2829           
+ Partials                 1075     1074    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CSSFrancis CSSFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericpre ericpre merged commit c82f85d into hyperspy:RELEASE_next_major Nov 30, 2023
30 checks passed
@ericpre ericpre deleted the python3.12 branch December 10, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants