Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate package metadata #3268

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 16, 2023

Similar as hyperspy/holospy#14 and others

Progress of the PR

  • Consolidate package metadata in pyproject.toml,
  • Tidy up outdated and unmaintained packaging files,
  • Use setuptools_scm to set version in package at build time,
  • Simplify GitHub CI workflows
  • Add python 3.12,
  • [n/a] docstring updated (if appropriate),
  • update user guide (releasing_guide.md),
  • added tests (package and test workflow),
  • add changelog entry,
  • ready for review.

@ericpre ericpre added this to the v2.0 Split milestone Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ec4ba8) 80.84% compared to head (5d00c59) 80.25%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_major    #3268      +/-   ##
======================================================
- Coverage               80.84%   80.25%   -0.60%     
======================================================
  Files                     140      147       +7     
  Lines                   20475    21854    +1379     
  Branches                 4838     5139     +301     
======================================================
+ Hits                    16553    17538     +985     
- Misses                   2859     3111     +252     
- Partials                 1063     1205     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre force-pushed the consolidate_package_metadata branch 3 times, most recently from b2918b7 to 81e3ce9 Compare December 7, 2023 10:12
@ericpre ericpre requested a review from jlaehne December 7, 2023 10:49
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@ericpre ericpre force-pushed the consolidate_package_metadata branch from 81e3ce9 to e12733f Compare December 7, 2023 18:00
@ericpre ericpre requested a review from jlaehne December 9, 2023 18:35
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
releasing_guide.md Outdated Show resolved Hide resolved
upcoming_changes/3268.maintenance.rst Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Co-authored-by: Jonas Lähnemann <jonas@pdi-berlin.de>
@ericpre ericpre merged commit c9f4a53 into hyperspy:RELEASE_next_major Dec 14, 2023
22 of 23 checks passed
@ericpre ericpre deleted the consolidate_package_metadata branch December 19, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants