Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker bugfix #3270

Merged
merged 3 commits into from Nov 29, 2023
Merged

Marker bugfix #3270

merged 3 commits into from Nov 29, 2023

Conversation

CSSFrancis
Copy link
Member

@CSSFrancis CSSFrancis commented Nov 20, 2023

Description of the change

These are just some small bugs I've found downstream in a couple of places.

See #3269 for more details.

Progress of the PR

  • Change implemented (can be split into several points),
  • add example
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

Minimal example of the bug fix or the new feature

print(hs.plot.markers.Points.from_signal(s))

(see the example for a more detailed example

@ericpre ericpre linked an issue Nov 21, 2023 that may be closed by this pull request
@ericpre ericpre added this to the v2.0 Split milestone Nov 21, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f75a8d7) 80.86% compared to head (206b6e4) 80.86%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_major    #3270      +/-   ##
======================================================
- Coverage               80.86%   80.86%   -0.01%     
======================================================
  Files                     140      140              
  Lines                   20400    20399       -1     
  Branches                 4826     4825       -1     
======================================================
- Hits                    16496    16495       -1     
- Misses                   2827     2829       +2     
+ Partials                 1077     1075       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre
Copy link
Member

ericpre commented Nov 29, 2023

I open #3274 to fix the test suite. Once #3274 is merged, we can rebase this PR.

@ericpre ericpre merged commit 224dca7 into hyperspy:RELEASE_next_major Nov 29, 2023
21 of 22 checks passed
@ericpre ericpre mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker Clean up
2 participants