New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beta warning lazy signal #3282
Remove beta warning lazy signal #3282
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3282 +/- ##
===================================================
Coverage 80.25% 80.25%
===================================================
Files 147 147
Lines 21854 21854
Branches 5139 5139
===================================================
Hits 17538 17538
Misses 3111 3111
Partials 1205 1205 ☔ View full report in Codecov by Sentry. |
@ericpre that sounds like a great idea. One thing to note is that distributed computing isn't really fully supported and should probably remain in beta. I thought I made an issue tracker for that but I don't know if I got around to it. As far as I know the samfire and matrix factorization (as well as downstream things like orientation mapping) are what isn't currently supported using lazy processing. In addition most file types aren't supported either (but I'm slowly adding more and more support) |
Yes, good point, instead of removing the warning, we should update it to be more specific.
|
I agree that the learning features should remain in beta. They still need a lot of polishing and some basic functionality, such as |
That sounds good to me!
I think you are right. I also think that the NNMF can have some problems with large datasets (if I remember). It needs to be rewritten to use That code should probably make its way into something like dask-ml. |
29ca124
to
0099073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
c024455
to
e848200
Compare
The lazy signal API has been used for several years and it is mature enough: it is stable and as of today, there is no reason that there will significant change any time soon in the API! Therefore, I think that it is fair to remove this warning! @francisco-dlp, @CSSFrancis, what do you think?