Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2.0 removal #3338

Merged
merged 2 commits into from Mar 21, 2024
Merged

numpy 2.0 removal #3338

merged 2 commits into from Mar 21, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 20, 2024

Use ruff check . --select NPY201 to find these.

For reference: https://numpy.org/devdocs/release/2.0.0-notes.html#numpy-2-0-python-api-removals.

Progress of the PR

  • Replace deprecated np.string_ by np.bytes_,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

@ericpre ericpre added this to the v2.0.2 milestone Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.51%. Comparing base (ccba4ff) to head (8192377).

Files Patch % Lines
hyperspy/model.py 0.00% 0 Missing and 2 partials ⚠️
hyperspy/misc/utils.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #3338   +/-   ##
===================================================
  Coverage               80.51%   80.51%           
===================================================
  Files                     147      147           
  Lines                   21869    21869           
  Branches                 5146     5146           
===================================================
  Hits                    17607    17607           
  Misses                   3044     3044           
  Partials                 1218     1218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit 9b2ed17 into hyperspy:RELEASE_next_patch Mar 21, 2024
27 of 29 checks passed
@ericpre ericpre deleted the fix_numpy2 branch March 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants