Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect linear fitting problems #574

Closed
francisco-dlp opened this issue Jun 16, 2015 · 3 comments · Fixed by #2422
Closed

Automatically detect linear fitting problems #574

francisco-dlp opened this issue Jun 16, 2015 · 3 comments · Fixed by #2422
Milestone

Comments

@francisco-dlp
Copy link
Member

It'll be useful to add an is_linear attribute to Parameter so that, if at fitting time all parameters are found to be linear it fits using least squares instead of non-linear least squares. This should dramatically increase the fitting speed in those cases.

TODO

[ ] Add is_linear attribute to all components.
[ ] Add linear least squares to fitters
[ ] Automatically use linear least squares when the problem is found to be linear
[ ] User Guide documentation
[ ] Docstring documentation
[ ] Tests

@tjof2
Copy link
Contributor

tjof2 commented Oct 11, 2017

See #1453 and #1462.

@thomasaarholt
Copy link
Contributor

thomasaarholt commented Oct 11, 2017

I've taken this up again as of this week. The fitting algorithm works, but not yet with convolution. I'd really enjoy it if someone would check out the PR (#1462), where I've merged the linear_parameters PR.

@tjof2
Copy link
Contributor

tjof2 commented Jul 17, 2020

See #2422 to replace the above links

@thomasaarholt thomasaarholt mentioned this issue Jul 17, 2020
5 tasks
@ericpre ericpre modified the milestones: Wish list, v1.7 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants