New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimal install and tidy up #13
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 76.54% 82.82% +6.27%
==========================================
Files 39 40 +1
Lines 8336 8051 -285
Branches 1931 1859 -72
==========================================
+ Hits 6381 6668 +287
+ Misses 1500 921 -579
- Partials 455 462 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f4d3e68
to
b8cd0f1
Compare
4bcf0dc
to
8f34d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that the coverage could also be increased notably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave the coverage improvement for another PR, as this one is already large enough and this is not the primary concern of this PR.
Progress of the PR
EMD
class in emd plugin,test_empad.py
module,traits
dependency,upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)