Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimal install and tidy up #13

Merged
merged 13 commits into from Aug 21, 2022
Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 16, 2022

Progress of the PR

  • Fix minimum install,
  • Allow to run test suite without hyperspy and add corresponding build to CI - most of the tests are skipped but this is useful to test import without hyperspy being installed,
  • Remove deprecated EMD class in emd plugin,
  • Fix teardown test_empad.py module,
  • remove leftover traits dependency,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #13 (784f1bd) into main (4ff3f4a) will increase coverage by 6.27%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   76.54%   82.82%   +6.27%     
==========================================
  Files          39       40       +1     
  Lines        8336     8051     -285     
  Branches     1931     1859      -72     
==========================================
+ Hits         6381     6668     +287     
+ Misses       1500      921     -579     
- Partials      455      462       +7     
Impacted Files Coverage Δ
rsciio/digital_micrograph/api.py 76.09% <ø> (-0.10%) ⬇️
rsciio/emd/api.py 85.46% <50.00%> (+19.48%) ⬆️
rsciio/conftest.py 71.42% <71.42%> (ø)
rsciio/utils/skimage_exposure.py 62.50% <75.00%> (ø)
rsciio/utils/array.py 85.71% <85.71%> (ø)
rsciio/__init__.py 100.00% <100.00%> (ø)
rsciio/image/api.py 91.56% <100.00%> (+24.06%) ⬆️
rsciio/tvips/api.py 98.47% <100.00%> (+<0.01%) ⬆️
rsciio/utils/rgb_tools.py 79.62% <100.00%> (ø)
setup.py
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that the coverage could also be increased notably.

MANIFEST.in Outdated Show resolved Hide resolved
rsciio/tests/test_blockfile.py Show resolved Hide resolved
rsciio/tests/test_bruker.py Show resolved Hide resolved
rsciio/tests/test_hdf5.py Show resolved Hide resolved
rsciio/tests/test_image.py Show resolved Hide resolved
rsciio/utils/skimage_exposure.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
rsciio/emd/api.py Show resolved Hide resolved
rsciio/emd/api.py Show resolved Hide resolved
rsciio/tests/test_emd_prismatic.py Show resolved Hide resolved
Copy link
Member Author

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the coverage improvement for another PR, as this one is already large enough and this is not the primary concern of this PR.

rsciio/tests/test_emd_prismatic.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
rsciio/tests/test_image.py Show resolved Hide resolved
rsciio/tests/test_blockfile.py Show resolved Hide resolved
rsciio/tests/test_hdf5.py Show resolved Hide resolved
rsciio/tests/test_msa.py Show resolved Hide resolved
rsciio/tests/test_bruker.py Show resolved Hide resolved
@jlaehne jlaehne merged commit 72eea4e into hyperspy:main Aug 21, 2022
@jlaehne jlaehne added this to the v0.1.0 initial release milestone Aug 29, 2022
@ericpre ericpre deleted the fix_minimal_install branch September 17, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants