New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renishaw survey image and marker for the mapping area #227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 86.23% 86.29% +0.05%
==========================================
Files 82 83 +1
Lines 10557 10592 +35
Branches 2295 2302 +7
==========================================
+ Hits 9104 9140 +36
Misses 934 934
+ Partials 519 518 -1 ☔ View full report in Codecov by Sentry. |
… example when using `FocusTrack_Z` or invariant series
b560547
to
ba75552
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
caf859e
to
e61e4e0
Compare
pre-commit.ci autofix |
6d5dac9
to
1e42c8e
Compare
Looks good. Though I would clarify in the docstring/documentation more exactly what is returned. The survey image is added as additional dictionary after the map's dictionary to the same object. For HyperSpy, I guess that translates into a stack of signals where first comes the actual map data and second the survey image? |
This is the same as for format that contains spectrum image and survey image or other any other data acquired simultaneously: For example with the file from the test suite: >>> s = hs.load(renishaw_test_streamline.wdf")
[<LumiSpectrum, title: StreamLine image acquisition 5, dimensions: (45, 49|394)>,
<Signal2D, title: , dimensions: (|376, 240)>] |
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)